Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PROJ 6 API for Georeferencing #1341

Merged
merged 10 commits into from
Sep 1, 2019
Merged

Use PROJ 6 API for Georeferencing #1341

merged 10 commits into from
Sep 1, 2019

Conversation

dg0yt
Copy link
Member

@dg0yt dg0yt commented Aug 30, 2019

No description provided.

When testing the calculated longitude, we must *multiply* the angular
error with a factor derived from the latitude, and we must pass the
latitude in *radians* to the cos function.
For the "LVermGeo RLP Pruem GK2" dataset, the error is slightly larger
than expected, so we need to increase the tolerance as well.
All tests pass with PROJ 4.9.3 (Ubuntu 18.04).
Task: GH-1325 (Geographic offset in CH1903+/LV95 with PROJ 6)
@dg0yt dg0yt force-pushed the georeferencing branch 3 times, most recently from 25ccda8 to 025ff81 Compare August 31, 2019 15:36
...instead of 'PROJ.4'.

User interface and user documentation need to be handled later.

The file format usage of 'PROJ.4 as an identifier will need more
thought: The legacy specs need to be supported for handling existing
maps, but PROJ now encourages specifying CRS as AUTHORITY:CODE or
by WKT strings instead of PROJ strings (cf.
https://proj.org/development/migration.html)
This matches the minimum version documented in INSTALL.md.
We can encapsulate the PROJ lib access and memory management
in a simple data type. This will facilitate providing a second
implementation for the new PROJ API.
The Android file handler is supported only for the new API now,
because we are not going to ship an old PROJ version again.
@dg0yt dg0yt mentioned this pull request Aug 31, 2019
@dg0yt dg0yt changed the title Georeferencing testing fixes, extension to EPSG:2056 Use PROJ 6 API for Georeferencing Aug 31, 2019
@dg0yt dg0yt merged commit 41672a8 into dev Sep 1, 2019
@dg0yt dg0yt deleted the georeferencing branch September 1, 2019 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant